From: Junio C Hamano Date: Sat, 04 Nov 2006 00:02:43 GMT Subject: Re: [PATCH 2/n] gitweb: Use '&iquot;' instead of '?' in esc_path Message-ID: <7vr6wk3wpo.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20061103225041.GQ20017@pasky.or.cz> Petr Baudis writes: > Dear diary, on Fri, Nov 03, 2006 at 11:44:48PM CET, I got a letter > where Junio C Hamano said that... >> Jakub Narebski writes: >> > Which solution do you think it's best? >> >> Sorry, if it was not clear in my message, I wanted to say that I >> kinda liked those "control pictures" in U+2400 range. > > In principle, right now it should be pretty easy for a project that for > some reason does not use UTF-8 in commits etc. to adjust gitweb to work > properly, right? Just change the encoding in HTTP headers and you're > done, I think. > > Is it worth trying to preserve that flexibility? Absolutely, and I got your point. Maybe \011 would be more portable and appropriate. Also munging [:cntrl:] would break iso-2022 encoding if it munges ESC, but the function under discussion was only for paths and I think no sane platform would use iso-2022 for filenames. Each repository has commit charset/encoding configuration item if I am not mistaken, so it is probably a sane thing to do to convert commit messages from that uniformly to utf-8, I think.