From: Junio C Hamano <junkio@cox.net>
Date: Sun, 14 Jan 2007 18:51:07 GMT
Subject: Re: [PATCH 2/4] Hash tags by commit SHA1 in git-describe.
Message-ID: <7vr6txh278.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0701141358440.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Sat, 13 Jan 2007, Shawn O. Pearce wrote:
>
>> If a project has a very large number of tags then git-describe
>> will spend a good part of its time looping over the tags testing
>> them one at a time to determine if it matches a given commit.
>
> Why not just use object_refs? This also obviates the need for your patch 
> 3/4, since you no longer have buckets to search binarily. Plus, it uses a 
> hash map, which already turned out to beat (in terms of performance) the 
> hell out of bucketed lists in git history.

Very good point.