From: Junio C Hamano <junkio@cox.net>
Date: Fri, 01 Jun 2007 19:44:36 GMT
Subject: Re: [PATCH] gitweb: use decode_utf8 directly
Message-ID: <7vr6ovzcgr.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <87zm3ju6tg.fsf@wine.dyndns.org>

Alexandre Julliard <julliard@winehq.org> writes:

> Sorry for the late nack, but it turns out that this patch breaks diff
> output on the Wine server for files that are not utf-8.
>
> The cause is apparently that decode_utf8() returns undef for invalid
> sequences instead of substituting a replacement char like
> decode("utf8") does.

Thanks for noticing.  Will revert.