From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 01 Nov 2007 22:26:34 GMT
Subject: Re: [PATCH] Make git-mailinfo strip whitespace from the start of the mail file.
Message-ID: <7vr6j98uw5.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <981e6de60711011441n5bef772cuda381c539c0a2603@mail.gmail.com>

"Simon Sasburg" <simon.sasburg@gmail.com> writes:

>> Just to help me understand why this change is needed...
>>
>> Are you using mailinfo directly without splitting with mailsplit
>> first?
>
> Well, when using gmail's web interface, when reading a mail, there is
> this option to show the raw mail text (headers+body) with the 'show
> original' option.
>
> If you do 'save as..' in your browser to save what you get with that,
> and try to do git-am on that file, it fails because it starts with
> some whitespace.
>
> With this patch git-am works on these files.
>
> So, i'm not using mailsplit or any other mail tools at all, just my
> browser and git.

Ah, I meant "git-mailsplit", which is the command internally run
by "git-am" to preprocess the file and to split it into
individual mail pieces to be fed to "git-mailinfo".

That may suggest the change is better done in git-mailsplit not
git-mailinfo.

Or perhaps both.