From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 28 Nov 2007 18:49:33 GMT
Subject: Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR
Message-ID: <7vr6ia5hoi.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <474D7D92.2000106@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Johannes Schindelin schrieb:
> ...
>>> Recently there was a report that \n in the substitution side of s/// is not
>>> supported by all seds :-(
>>
>> Okay, how about replacing the line with
>>
>> +			s/.*/GIT_'$uid'_NAME='\''&'\''\
>> +export GIT_'$uid'_NAME/p
>>
>> Hmm?  (It works here.)
>
> This looks good. The other case I'm refering to was also solved in this way.

That looks ugly to me.

Is there a particular reason to force linebreak when a semicolon would
do?