From: Junio C Hamano Date: Sun, 10 Feb 2008 02:36:08 GMT Subject: Re: [PATCH TAKE 2] Avoid a useless prefix lookup in strbuf_expand() Message-ID: <7vr6fl5yhz.fsf@gitster.siamese.dyndns.org> In-Reply-To: <1202568019-20200-1-git-send-email-mcostalba@gmail.com> Marco Costalba writes: > Currently the --prett=format prefix is looked up in a s/prett/&y/; > New patch with Junio suggestions included. Hmph, this is a blast from the past. I do recall pointing out that a rather common "format:%an <%ae>" ends up parsing the same line twice, and mentioned we may want to memoise the first call's result in the format_commit_context structure, but what else did I suggest??? Anyway, I'll take a look later. Thanks.