From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 19 Jun 2008 03:03:13 GMT
Subject: Re: [PATCH] Make git_dir a path relative to work_tree in setup_work_tree()
Message-ID: <7vr6auw2ha.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.1.00.0806181949160.19665@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

>  	if (initialized)
>  		return;
> -	work_tree = get_git_work_tree();
> +	work_tree = xstrdup(make_absolute_path(get_git_work_tree()));

Might be a nice try, but Oops, I suspect.

Doesn't the presense of "if (!work_tree..." below tell you that the
function you are calling can legitimately return NULL?