From: Junio C Hamano Date: Wed, 23 Jul 2008 00:12:50 GMT Subject: Re: [PATCH] Build configuration to skip ctime for modification test Message-ID: <7vr69lihkt.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080722203128.GB5113@blimp.local> Alex Riesen writes: > Johannes Schindelin, Tue, Jul 22, 2008 22:17:21 +0200: >> Hi, >> >> On Tue, 22 Jul 2008, Alex Riesen wrote: >> >> > +#ifndef NO_TRUSTABLE_FILEMODE >> > if (ce->ce_ctime != (unsigned int) st->st_ctime) >> > changed |= CTIME_CHANGED; >> > +#endif >> >> Surely you meant trust_executable_bit instead, right? > > No. Just what I said: we don't have filemode (like "at all") - so no > ctime as well. But maybe you're right, and trust_executable_bit is > more flexible. Or maybe both (the #ifdef _and_ trust_executable_bit) > and must be used... > >> Otherwise, if you really want to tell at compile time,I think for clarity >> you have to introduce another #define, since NO_TRUSTABLE_FILEMODE >> definitely says something different than CTIME_IS_USELESS. > > I had that at first (NO_DEPENDABLE_CTIME, than IGNORE_CTIME), than > deemed it excessive. Why is it excessive? My initial reaction was "what does trustable filemode nor trust_executable_bit has anything to do with ctime". Please explain.