From: Junio C Hamano Date: Mon, 19 Jan 2009 03:38:06 GMT Subject: Re: [PATCH/RFC] git-am: Make it easier to see which patch failed Message-ID: <7vr630rmn5.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20090118153928.GA16664@coredump.intra.peff.net> Jeff King writes: > Yes, I'm surprised Junio doesn't remember the mass conversions we already had > to do (4b7cc26a and 293623ed). But looking at the date, I guess it _has_ > been a year and a half. :) Ok, I forgot, sue me ;-). Anyway, thanks for spotting. I'll fix it up like this. -- >8 -- Subject: git-am: re-fix the diag message printing The $FIRSTLINE variable is from the user's commit and can contain arbitrary backslash escapes that may be (mis)interpreted when given to "echo", depending on the implementation. Use "printf" to work around the issue. Signed-off-by: Junio C Hamano --- git-am.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-am.sh b/git-am.sh index ae2fe56..cf3d4a7 100755 --- a/git-am.sh +++ b/git-am.sh @@ -501,7 +501,7 @@ do fi if test $apply_status != 0 then - echo "Patch failed at $msgnum $FIRSTLINE" + printf 'Patch failed at %s %s\n' "$msgnum" "$FIRSTLINE" stop_here_user_resolve $this fi -- 1.6.1.245.gdd9f9