From: Junio C Hamano Date: Wed, 28 Jan 2009 21:32:04 GMT Subject: Re: [PATCH] diff.c: output correct index lines for a split diff Message-ID: <7vr62nktgr.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20090126090712.GA12648@coredump.intra.peff.net> Jeff King writes: > On Mon, Jan 26, 2009 at 12:33:56AM -0800, Junio C Hamano wrote: > >> This moves the code to generate metainfo lines around, so that two >> independent sets of metainfo lines are used for the split halves. > > The patch and the generated output look correct to me, so > > Acked-by: Jeff King > >> I did not include your new test script here; perhaps we can add it to an >> existing typechange diff/apply test, like t4114? > > I think it makes sense to add to t4114. Please squash in the test below. Thanks.