From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 22 Mar 2009 05:36:06 GMT
Subject: Re: [PATCHv2 2/3] format-patch: --attach/inline uses filename instead of SHA1
Message-ID: <7vr60q86gp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1237696363-6819-3-git-send-email-bebarino@gmail.com>

Stephen Boyd <bebarino@gmail.com> writes:

> Currently when format-patch is used with --attach or --inline the patch
> attachment has the SHA1 of the commit for its filename. This replaces
> the SHA1 with the filename used by format-patch when outputting to files.
>
> Fix tests relying on the SHA1 output and add a test showing how the
> --suffix option affects the attachment filename output.
>
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> ---
> Is modifying the rev_info struct correct?

Most of the rev_info is about the overall traversal not about individual
commits, and I think the new field you are adding is about a single commit
you will update every time you switch to a new commit to process, so in
that sense it may violate the general idea of what rev-info is, but I do
not think it matters too much.