From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 01 Jun 2009 16:33:20 GMT
Subject: Re: [PATCH 10/11] Fix warnings in nedmalloc when compiling with GCC 4.4.0
Message-ID: <7vr5y3lxrj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0906011054410.26154@pacific.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> > diff --git a/compat/nedmalloc/nedmalloc.c b/compat/nedmalloc/nedmalloc.c
>> > index a381a7d..60a4093 100644
>> > --- a/compat/nedmalloc/nedmalloc.c
>> > +++ b/compat/nedmalloc/nedmalloc.c
>> > @@ -34,7 +34,7 @@ DEALINGS IN THE SOFTWARE.
>> >  /*#define FULLSANITYCHECKS*/
>> >  
>> >  #include "nedmalloc.h"
>> > -#if defined(WIN32) && !defined(__MINGW32__)
>> > +#if defined(WIN32)
>> >   #include <malloc.h>
>> >  #endif
>> 
>> Can somebody enlighten me what this hunk is about, and how it helps GCC
>> 4.4?
>
> It helps in that malloc.h is included even if we happen to compile the 
> stuff as a MinGW program.  Otherwise necessary function declarations are 
> missing.
> ...
> Hopefully less so, now.

I wish enough information were in the commit log message from the
beginning.