From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 27 Jun 2009 01:03:05 GMT
Subject: Re: [PATCHv6 7/8] gitweb: recognize 'trivial' acks
Message-ID: <7vr5x6mqt2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1245926587-25074-8-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

>  	foreach my $line (@$log) {
> -		if ($line =~ m/^ *(signed[ \-]off[ \-]by[ :]|acked[ \-]by[ :]|cc[ :])/i) {
> +		if ($line =~ m/^ *(signed[ \-]off[ \-]by[ :]|(?:trivially[ \-])?acked[ \-]by[ :]|cc[ :])/i) {

Wouldn't it make more sense to do something like:

	if ($line =~ m/^[-a-z]+: (.*)$/i && looks_like_a_name_and_email($1)) {
            	... do the avatar thing ...
	}

and limit this processing only to the last run of no-blank lines?