From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 04 Dec 2009 17:16:45 GMT
Subject: Re: Running commands in wrong environment
Message-ID: <7vr5raslqa.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091204104441.GD27495@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> But the consequences, as you mention, could include data loss, which
> argues for being on the safe side. In that case, we would probably want
> an "xsetenv" to die() if we fail to avoid cluttering the code
> everywhere.
>
> I dunno. If we're going to do it, it is probably maint-worthy. Junio?

My gut feeling is xsetenv/xputenv would be sufficient.  I do not think we
make any setenv/putenv that we do not care about failing, perhaps other
than the "if LESS is not there set it to this default value, as it would
give users nicer experience if they use 'less'."