From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 12 Jan 2010 09:05:23 GMT
Subject: Re: [PATCH 04/18] date.c: mark file-local function static
Message-ID: <7vr5pv3d7w.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B4C34B3.3010508@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

>> diff --git a/git-compat-util.h b/git-compat-util.h
>> index 5c59687..85dea12 100644
>> --- a/git-compat-util.h
>> +++ b/git-compat-util.h
>> @@ -198,7 +198,6 @@ extern void warning(const char *err, ...) __attribute__((format (printf, 1, 2)))
>>  extern void set_die_routine(NORETURN_PTR void (*routine)(const char *err, va_list params));
>>  
>>  extern int prefixcmp(const char *str, const char *prefix);
>> -extern time_t tm_to_time_t(const struct tm *tm);
>>  
>>  static inline const char *skip_prefix(const char *str, const char *prefix)
>>  {
>
> This one is used from compat/mingw.c for the gettimeofday emulation.
> Please leave it extern.

Ouch; I thought I ran "git grep <sym> pu" for all of them.
Sorry and thanks.