From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 14 Sep 2010 15:59:56 GMT
Subject: Re: [PATCH 3/8] tree_entry_interesting(): remove dependency on struct diff_options
Message-ID: <7vr5gw8geb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1283961023-4491-4-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> This function can be potentially used in more places than just
> tree-diff.c. "struct diff_options" does not make much sense outside
> diff_tree_sha1().
>
> Moreover people seem to be agree that diff machinery should learn
> proper pathspecs too (i.e. globbing, negative pathspecs...), not just
> treating pathspecs as tree prefix.

There is nothing improper about the prefix match.  Perhaps "richer"?
I am not so sure about the need/desirability of negative match, but we
will see. 

About naming.  Where else other than "tree" (in the "hierarchical
namespace" sense) context do you see pathspec?  Does the struct really
need to be called TREE_pathspec_list?