From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 31 Oct 2010 03:31:48 GMT
Subject: Re: [PATCH en/cascade-tests] tests: add missing &&
Message-ID: <7vr5f73umz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101031014654.GC29456@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

> @@ -27,7 +27,7 @@ test_expect_success 'see what we expect' '
>  	>junk/"$auml" &&
>  	case "$(cd junk && echo *)" in
>  	"$aumlcdiar")
> -		test_unicode=test_expect_failure
> +		test_unicode=test_expect_failure &&
>  		unibad=t
>  		;;
>  	*)	;;

This seems to prepare for a case where a simple variable assignment fails
for whategver reason, which is not too bad, but ...

> @@ -36,7 +36,7 @@ test_expect_success 'see what we expect' '
>  	{
>  		ln -s x y 2> /dev/null &&
>  		test -h y 2> /dev/null ||
> -		no_symlinks=1
> +		no_symlinks=1 &&
>  		rm -f y

... if you allowed such a simple assignment failure, no_symlinks=1 may
fail, and we end up not running "rm -f y" to clean up, which might be
somewhat undesirable ;-)

Looked up to but not including t5302 and all looked Ok.