From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 14 Nov 2010 19:12:05 GMT
Subject: Re: [PATCH 1/4] Makefile: move "Platform specific tweaks" above LIB_{H,OBJS}
Message-ID: <7vr5en1zzu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTinaDhXQjPC6s1eFb8HwEReW7P-ObmwRn2Hpb=O4@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>> This doesn't motivate the patch all all to me.  Is changing the list
>> of LIB_OBJS in section C1 really an ugly hack?  It is where
>> configuration-specific things go and how BLK_SHA1, PROGRAM_OBJS, etc
>> work already.
>
> Yeah, because if it hadn't come before A8 it would have been *not*
> assigned to in the first place like we do everywhere else. Moving A8
> before A5 enables us to do that.

Hmm, in the existing platform specific tweaks section, we set BLK_SHA1
based on $(uname_S) and that symbol is used to control what is added to
LIB_H and LIB_OBJS.  Why is your gettext.o any different?