From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Nov 2010 22:20:13 GMT
Subject: Re: [PATCHv7.1 3/4 (amend)] gitweb: File based caching layer (from git.kernel.org)
Message-ID: <7vr5e3zs9u.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vvd3fzskv.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Jakub Narebski <jnareb@gmail.com> writes:
>
>>> I have made mistake with this line when moving $caching_enabled check
>>> out of cache_fetch to its caller.
>>> 
>>> Reusing $fullhashpath variable as a *capture buffer* (it has nothing
>>> to do with path; it is not a filename no longer) wouldn't help there.
>>
>> Errr... I meant that this abuse didn't help avoiding my mistake.
>
> Thanks.

Wait a bit.

This seems to match what I have already queued on 'pu', no?  Am I
hallucinating?