From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 18 Dec 2010 21:02:50 GMT
Subject: Re: [PATCH v2 3/4] userdiff: fix typo in ruby and python word regexes
Message-ID: <7vr5deg5fp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <a358c476187b1220bf6e2368c0723cefe60a5763.1292688058.git.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

> Both had an unclosed ] that ruined the safeguard against not matching
> a non-space char.

Thanks.

Couldn't we have found this without your "sanity check" patch?  Are we
ignoring error returns from regcomp() in some codepath, or is it just that
we are catching them but our test suite lacks ruby and python test
vectors?