From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 02 Aug 2011 18:00:18 GMT
Subject: Re: [PATCH v13 4/8] bisect: introduce support for --no-checkout option.
Message-ID: <7vr553elsd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1312284545-2426-5-git-send-email-jon.seymour@gmail.com>

Jon Seymour <jon.seymour@gmail.com> writes:

> If --no-checkout is specified, then the bisection process uses:
>
> 	git update-ref --no-deref HEAD <trial>
>
> at each trial instead of:
>
> 	git checkout <trial>
> ...

Ok.

>  int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
>  {
>  	int next_all = 0;
> +	int no_checkout = 0;
> +	char *bisect_mode=NULL;
>  	struct option options[] = {
>  		OPT_BOOLEAN(0, "next-all", &next_all,
>  			    "perform 'git bisect next'"),
> +		OPT_STRING(0, "bisect-mode", &bisect_mode, "mode",
> +			    "the bisection mode either checkout or update-ref. defaults to checkout."),

I think this is a regression from naming perspective from the previous
round. You would be either the normal (checkout) mode or no-checkout mode,
and honestly, --no-checkout would be understood by anybody while update-ref
would be understood only by Gitz.