From: Junio C Hamano Date: Thu, 08 Sep 2011 16:46:21 GMT Subject: Re: [PATCHv2 1/2] remote: write correct fetch spec when renaming remote 'remote' Message-ID: <7vr53rx9r6.fsf@alter.siamese.dyndns.org> In-Reply-To: Martin von Zweigbergk writes: > On Wed, 7 Sep 2011, Junio C Hamano wrote: > >> Later in the same mv() function, the other one renames refs/remotes/$OLD/ >> to refs/remotes/$NEW/, even when you did not find any fetch refspec that >> stores under "refs/remotes/$OLD/" in the earlier logic. > > Ah, of course. Sorry for being slow and thanks for the explanation. So > if there are two configured refspecs with RHSs "refs/remotes/$OLD/foo" > and "refs/remotes/$OLD/bar/*", we should remember that we updated > those and only update refs that match the same patterns. I will see > what I can do and will hopefully soon get back with a "patch 4/2". What I had in mind was nothing that elaborate--it would be sufficiently safe to just remember if you replaced any in the config, and if you didn't, not to move anything.