From: Junio C Hamano Date: Wed, 07 Mar 2012 23:39:43 GMT Subject: Re: [PATCH v3 1/3] Fix memory leak in apply_patch in apply.c. Message-ID: <7vr4x4j800.fsf@alter.siamese.dyndns.org> In-Reply-To: Jared Hance writes: > In the while loop inside apply_patch, patch is dynamically allocated > with a calloc. However, only unused patches are actually free'd; the > rest are left in a memory leak. Since a list is actively built up > consisting of the used patches, they can simply be iterated and free'd > at the end of the function. > ... Thanks. This more-or-less looks good modulo minor style issues. We might also want to make rejected a one-bit bitfield that sits next to the new free_patch field to share the same word, but that is a separate topic. Will queue.