From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 22 Mar 2013 14:48:37 GMT
Subject: Re: [PATCH] t7600: merge tag shoud create a merge commit
Message-ID: <7vr4j78p8a.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1363949850-11927-1-git-send-email-y>

y@quest-ce.net writes:

> From: Yann Droneaud <ydroneaud@opteya.com>
>
> This test ensures a merge commit is always created
> when merging an annotated (signed) tag without --ff-only option.
>
> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> ---
>
> Here's a proposition for a test tath check the creation of a merge commit
> when merging a tag.
>
> It's not in final shape: the line 
>
>     EDITOR=false test_must_fail git merge signed

Because test_must_fail is a shell function, single-shot environment
assignment like this should not be used.