From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Apr 2013 18:10:15 GMT
Subject: Re: [PATCH 1/2] diffcore-pickaxe: respect --no-textconv
Message-ID: <7vr4iqi2uw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130404175150.GA15630@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I'm OK with this as-is, but I would also be happy to see the re-ordering
> and extra cleanup I mentioned elsewhere.

Yeah, I agree that the order is the other way around.  2/2 could be
retitled to say that fill_one() no longer needs to touch, but swapping
the order with the extra clean-up would be much cleaner.

>
> But either way:
>
>   Acked-by: Jeff King <peff@peff.net>
>
> -Peff