From: Junio C Hamano <junkio@cox.net>
Date: Sat, 11 Feb 2006 02:21:30 GMT
Subject: Re: [PATCH] Don't propagate SKIPPED warning to future commits.
Message-ID: <7vpslutz2t.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <87r76avfhz.wl%cworth@cworth.org>

Carl Worth <cworth@cworth.org> writes:

> Here's a simple bug fix for the (currently undocumented) -S flag to
> git-cvsimport.
>
> The -S flag allows an import to proceed in the face of a missing ,v
> file in the CVS repository. It marks this by adding a SKIPPED warning
> in the relevant commit.
>
> Without this patch, the SKIPPED warning propagates to all future
> commits, (and accumulates with future SKIPPED warnings).

I might be missing something fundamental, but isn't prapagating
the warning a good thing?  If an earlier commit is suspected to
lack some path that needs to be there (I think that is what
"missing ,v file" means), wouldn't later commits built on top of
that one be by definition missing that path?