From: Junio C Hamano Date: Sun, 11 Mar 2007 03:07:13 GMT Subject: Re: [PATCH] prepare_packed_git(): sort packs by age and localness. Message-ID: <7vps7gxyu6.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20070311023422.GE10343@spearce.org> "Shawn O. Pearce" writes: > Junio C Hamano wrote: >> When accessing objects, we first look for them in packs that >> are linked together in the reverse order of discovery. >> >> Since younger packs tend to contain more recent objects, which >> are more likely to be accessed often, and local packs tend to >> contain objects more relevant to our specific projects, sort the >> list of packs before starting to access them. In addition, >> favoring local packs over the ones borrowed from alternates can >> be a win when alternates are mounted on network file systems. > > ACK. But... > >> diff --git a/cache.h b/cache.h >> @@ -431,6 +432,7 @@ extern off_t find_pack_entry_one(const unsigned char *, struct packed_git *); >> +void rearrange_packed_git(void); > > Is that really necessary to make public? The next patch in the series was going to sort in a different order (giving it a parameter to control the sort order) that is more suitable while repacking, but it seems that the patch is not needed.