From: Junio C Hamano <junkio@cox.net>
Date: Fri, 16 Mar 2007 09:32:19 GMT
Subject: Re: [PATCH] git-fetch, git-parse-remote: Cleanup implementation of '.'
Message-ID: <7vps79v8ik.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <45FA5771.1040200@lu.unisi.ch>

Paolo Bonzini <paolo.bonzini@lu.unisi.ch> writes:

> 	The patch is a cleanup of the one you posted, and it was
> 	appropriately tested with no regression.
>
> 	I can see now what you meant by the split between fetch and
> 	merge logic making my patch more complicated than necessary.

Thanks.  I'll squash the two and apply.

> +	builtin)
> +	        canon_refs_list_for_fetch -d "$1" \
> +			$(git-show-ref | sed -n 's,.*[      ]\(refs/.*\),\1:,p') ;;

I may not be really thinking straight tonight (no I am not
drunk, but just a tad sick), but I wonder if this is sufficient?

	$(git-for-each-ref --format='%(refname):')

Shorter and one less process and pipe.