From: Junio C Hamano <junkio@cox.net>
Date: Mon, 30 Apr 2007 23:19:04 GMT
Subject: Re: [PATCH 1/5] Introduces for_each_revision() helper
Message-ID: <7vps5lbgd3.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070429070616.GV5942@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> But in_merge_base is heavyweight if the two commits are in the
> same object database, but aren't connected at all.  You'll need
> to traverse both histories before aborting and saying there is
> no merge base.  That ain't cheap on large trees.  But its also a
> single line of code.

Who said anything about "a single line of code"?  That is quite
different from heaviness hidden in a control structure
lookalike.