From: Junio C Hamano Date: Sat, 16 Jun 2007 05:31:06 GMT Subject: Re: [PATCH/RFH] pp_header(): work around possible memory corruption Message-ID: <7vps3w4g9x.fsf@assigned-by-dhcp.pobox.com> In-Reply-To: At least the older humongous pretty_print_commit() got separated into manageable chunks, and I was happy. I was just too lazy when refactoring the code and stopped there. The right fix is to propagate the "realloc as needed" callchain into add_user_info(), instead of having "this should be enough" there. These two you touched are the only two callsite of that static function.