From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 22 Nov 2007 09:13:47 GMT
Subject: Re: [PATCH] Add path-limiting to git-add--interactive
Message-ID: <7vpry27id0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1195695384-41329-1-git-send-email-win@wincent.com>

Wincent Colaiuta <win@wincent.com> writes:

> @@ -56,9 +56,14 @@ sub list_modified {
>  	my ($only) = @_;
>  	my (%data, @return);
>  	my ($add, $del, $adddel, $file);
> +	my @tracked = grep {
> +		defined run_cmd_pipe(qw(git ls-files
> +			                --exclude-standard --), $_)
> +	} @ARGV;
> +	return if $#tracked == -1 && $#ARGV != -1;

Eek.  why?

Did you mean to say:

    my @tracked = run_cmd_pipe(gw(git ls-files --exclude-standard --) @ARGV);

It would also make sense to use --error-unmatch and perhaps --with-tree=HEAD
like git-commit.sh does.