From: Junio C Hamano Date: Wed, 06 May 2009 21:49:15 GMT Subject: Re: [PATCH 4/4] t4200: avoid passing a non-newline terminated file to sed Message-ID: <7vpreluckk.fsf@alter.siamese.dyndns.org> In-Reply-To: Brandon Casey writes: > The 'sha1' variable that is set here on line 193 is used on the next line > to set 'rr', but 'rr' is never used again. Unless I'm missing something, > it appears these two lines can be deleted. Yeah, it looks like this is a mindless cut&paste; I do not see the point of setting rr there unless it is used to make sure that a corresponding rerere cache is created, or something.