From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 29 Dec 2009 16:58:35 GMT
Subject: Re: [PATCH] Wrap completions in `type git' conditional statement.
Message-ID: <7vpr5xg1j8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091229150217.GB6152@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Nanako Shiraishi <nanako3@lavabit.com> wrote:
>> Junio, could you tell us what happened to this thread?
>> 
>> The patch avoids failing completion script when git is not there.
>> No discussion.
>
> Actually, that's probably my fault.  I never sent an ack or nak,
> or anything else really, on this thread.
>
> Originally this was because the completion was trying to run git
> as it loaded.  In 1.6.6 this is no longer true, the completion list
> is generated lazily on demand during the first completion attempt.
>
> With the lazy loading, I didn't see a reason to add this ugly block
> around the entire script.

Thanks, both.