From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Feb 2010 16:33:09 GMT
Subject: Re: [PATCH 1/4] gitweb: notes feature
Message-ID: <7vpr4lhsfu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1265300338-25021-2-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

> +		my %notes = () ;
> +		foreach my $note_ref (@note_refs) {
> +			my $obj = "$note_ref:$co{'id'}";

I think this look-up is wrong (meaning: will stop working anytime in the
future, and needs to be rewritten).

Other parts of this patch looked Ok from a cursory reading, though.