From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 05 Jun 2010 06:38:39 GMT
Subject: Re: [PATCH 1/4] diff/xdiff: refactor EOF-EOL detection
Message-ID: <7vpr060ys0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4C08AD75.6040307@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

> In 3/4, that "No NL at EOF" is suppressed for symlinks *when textconv is
> in effect only*, i.e. when we don't (necessarily) produce a diff fit to
> be applied anyways.

Sorry, that doesn't change a thing at all.  The presense of incomplete
line is part of the information diff gives you.

It can be done by defining a custom textconv filter that adds a trailing
LF to a blob that ends in an incomplete line, and what your patch 3/4 does
is essentially to create such a built-in textconv filter and *force* users
to use it unconditionally for all paths unless the user explicitly asks
not to use *any* textconv.