From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 24 Nov 2010 20:28:22 GMT
Subject: Re: [PATCH/RFC] fast-import: treat SIGUSR1 as a request to access objects early
Message-ID: <7vpqtusbyx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101122081601.GA9722@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

> +static void parse_checkpoint(void)
> +{
> +	do_checkpoint();
>  	skip_optional_lf();
>  }

I would have expected the new implementation of parse_checkpoint() to just
set the checkpoint_requested variable to true, so that the checkpoint
always happens in the main loop, which somehow feels cleaner.  But that is
a minor point.