From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 07 Jan 2011 18:48:36 GMT
Subject: Re: [PATCH 3/4] test: use test_utf8 and GIT_LC_UTF8 where an en_US.UTF-8 locale is required
Message-ID: <7vpqs87dob.fsf@alter.siamese.dyndns.org>
In-Reply-To: <97423472c08cd83373c769bf1cafdb9b85db37e3.1294312018.git.yann@droneaud.fr>

Yann Droneaud <yann@droneaud.fr> writes:

> Signed-off-by: Yann Droneaud <yann@droneaud.fr>
> ---
>  t/t9100-git-svn-basic.sh               |   25 ++++++++-----------------
>  t/t9129-git-svn-i18n-commitencoding.sh |   13 +++----------
>  2 files changed, 11 insertions(+), 27 deletions(-)

Both are nice changes; this patch shows the earlier abstraction in 2/4 is
the right direction to go.

>  compare_svn_head_with () {
>  	# extract just the log message and strip out committer info.
>  	# don't use --limit here since svn 1.1.x doesn't have it,
> -	LC_ALL="$a_utf8_locale" svn log `git svn info --url` | perl -w -e '
> +	LC_ALL=$GIT_LC_UTF8 svn log `git svn info --url` | \
> +	    LC_ALL=$GIT_LC_UTF8 perl -w -e '

Style.

	LC_ALL=... svn log ... |
        LC_ALL=... perl -w -e '
        	...
	'

When you end a line with '|', the shell knows that you haven't finished
talking to it, so there is no need for the trailing bs-lf there.  Indent
the downstream of the pipe to the same level as the upstream.