From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 19 Jun 2011 22:50:04 GMT
Subject: Re: [PATCH 1/6] Bring notes.c template handling in line with commit.c.
Message-ID: <7vpqm9e8rn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201106192323.09511.johan@herland.net>

Johan Herland <johan@herland.net> writes:

> On Saturday 18 June 2011, Yann Dirson wrote:
>> Signed-off-by: Yann Dirson <ydirson@free.fr>
>
> Please mention in the commit message that the commit merely replaces 
> write_or_die()/int fd with the corresponding stdio functionality, and that 
> there is no (intended) change in behavior. It was not apparent from your 
> commit message that you had not made any other changes.
>
> Otherwise the patch looks OK.

I had an impression that you would lose a lot of error checking, unless
you are careful, if you go from write_or_die() to stdio.