From: Junio C Hamano Date: Thu, 23 Jun 2011 17:17:30 GMT Subject: Re: [RFC/PATCH 2/3] small-alloc: add allocator for small objects Message-ID: <7vpqm431sl.fsf@alter.siamese.dyndns.org> In-Reply-To: <1308728011-14136-3-git-send-email-davidbarr@google.com> David Barr writes: > This allocator assigns an integer handle to each allocation which can be > used to retrieve the pointer to the start of the allocation and its > length. One more thing to add to yesterday's review. I think you would need to include a "method" that initializes a mem_pool object, and possibly another to destroy an existing one, freeing the resources (unless the API is meant to replace something like obj_hash in object.c). It was quite difficult to judge how good this API is as it took imagination on the reviewer's part on how a typical caller would look like.