From: Junio C Hamano Date: Fri, 09 Mar 2012 22:26:15 GMT Subject: Re: [PATCH] tests: modernise style: more uses of test_line_count Message-ID: <7vpqcl4diw.fsf@alter.siamese.dyndns.org> In-Reply-To: <08c65508e2a643cb3352b829675f79d592c917cb.1331329464.git.stefano.lattarini@gmail.com> Stefano Lattarini writes: > This change modernizes one (and just one) kind of obsolescent idiom > throughout (almost) all the tests, rather than tweaking one single test > with lots of different and unrelated modernizations. This approach > seems safer, and IMHO makes for patches easier to write and review. Yes, but during the pre-release "regression fix only" period is not a good time to do so.