From: Junio C Hamano Date: Thu, 24 May 2012 16:52:25 GMT Subject: Re: What's cooking in git.git (May 2012, #06; Wed, 23) Message-ID: <7vpq9ty112.fsf@alter.siamese.dyndns.org> In-Reply-To: <4FBDC8FA.9050501@lsrfire.ath.cx> René Scharfe writes: > Am 24.05.2012 00:24, schrieb Junio C Hamano: >> * rs/maint-grep-F (2012-05-21) 4 commits >> (merged to 'next' on 2012-05-23 at b24143c) >> + grep: stop leaking line strings with -f >> + grep: support newline separated pattern list >> + grep: factor out do_append_grep_pat() >> + grep: factor out create_grep_pat() >> >> "git grep -F", unlike the case where it reads from a file, did not treat >> individual lines in the given pattern argument as separate patterns as it >> should. > > This is not specific to -F; grep(1) accepts newline-separated pattern > lists with -E etc. as well, as does git grep with the patches above. Yeah, I noticed that "unlike where reading from a file" should contrast against "where params come from the command line", not with any particular way to interpret individual pattern. after sending it out. Thanks.