From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 20 Jun 2012 18:44:25 GMT
Subject: Re: [PATCH v3] diff-no-index: exit(1) if 'diff --quiet <repo file> <external file>' finds changes
Message-ID: <7vpq8tvn5i.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120620160607.GA12856@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Fine by me. I think "xdiff_found_changes" is not quite accurate; it is
> really "did builtin_diff find any changes?" since we might never call
> into xdiff (e.g., for binary files). I'm not sure what the best name is.

"diffopt.found_changes" is clear enough for me.