From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 21 Aug 2012 03:49:42 GMT
Subject: Re: receive.denyNonNonFastForwards not denying force update
Message-ID: <7vpq6kgazt.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120821015738.GA20271@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Aug 20, 2012 at 06:22:26PM -0700, Junio C Hamano wrote:
>
>> Does anybody recall if this is something we did on purpose?  After
>> eyeballing the callchain starting from cmd_receive_pack() down to
>> receive_pack_config(), nothing obvious jumps at me.
>
> No, I do not think it was on purpose. And it would be very hard to do
> so, anyway; config callbacks are not given any information about the
> source of the config variable, and cannot distinguish between repo,
> global, and system-level config variables.

I was looking for setenv() to refuse system wide defaults; that
actually is fairly simple.

>> Could this be caused by a chrooted environment not having
>> /etc/gitconfig (now I am just speculating)?
>
> That seems far more likely to me. Another possibility is that the file
> is not readable by the user running receive-pack.

Good point. We explicitly use access(R_OK) and pretend as if a path
that is known to exist but not readable is missing; perhaps we may
want to diagnose this as a misconfiguration and issue a warning?