From: Junio C Hamano Date: Wed, 23 Jan 2013 07:04:45 GMT Subject: Re: [PATCHv2 8/8] reflog: use parse_config_key in config callback Message-ID: <7vpq0widma.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130123062737.GH5036@sigill.intra.peff.net> Jeff King writes: > This doesn't save any lines, but does keep us from doing > error-prone pointer arithmetic with constants. Yeah, this and 7/8 shows that the true value of the new parse function is not line number reduction but clarity of the calling code. There is really no point making everybody implement "last_dot is there, so the subsection name must be between the section name and that last_dot" like the original before this patch. Thanks. Will read it over again and then apply.