From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Apr 2013 21:22:46 GMT
Subject: Re: [PATCH 2/2] decorate: add "clear_decoration()"
Message-ID: <7vppy4vhsp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130408210903.GC9649@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Sun, Apr 07, 2013 at 11:14:17PM -0700, Junio C Hamano wrote:
>
>> So far, all the users of the decoration API used decoration that
>> only grows and discarded at the end of the program execution.
>> 
>> Introduce for_each_decoration() that lets the caller iterate over
>> all defined decorations and use it to implement clear_decoration()
>> function.
>> 
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> Both this and the first patch look good to me. I had documented
> api-decorate long ago as part of the cache-metadata-on-disk series (it
> was built on generic maps, which I also refactored decorate on top of).
> But I didn't see anything in my version that was missing from yours (in
> fact, it was much sparser, because it just referred to the generic map
> api, which we never merged).
>
> Out of curiosity: where is the patch 3 that presumably led you to
> wanting these?

It is nowhere near ready to be published, as I am not finding any
time for coding today X-<.