From: Junio C Hamano Date: Mon, 13 May 2013 05:02:39 GMT Subject: Re: [RFC/PATCH 0/2] merge-base: add --merge-child option Message-ID: <7vppwvqxow.fsf@alter.siamese.dyndns.org> In-Reply-To: <518FD182.5020606@bracey.fi> Kevin Bracey writes: > On 12/05/2013 19:58, John Keeping wrote: >> >> With the patch below, the --ancestry-path version drops to under 2 >> seconds. >> >> I'm not sure if this is a good idea though. It helps me say "I know >> nothing that isn't on the ancestry path can be patch-identical, so don't >> bother checking if it is" but it regresses users who want the full >> cherry-pick check while only limiting the output. > > Hmm. Should an excluded commit be a valid comparator? Is it > sensible/correct to show a left commit as "=" to a right commit that > has been excluded by the revision specifiers? Doesn't sound right to > me. Neither to me.