From: Junio C Hamano Date: Tue, 04 Jun 2013 16:50:12 GMT Subject: [PATCH] t/README: test_must_fail is for testing Git Message-ID: <7vppw195x7.fsf_-_@alter.siamese.dyndns.org> In-Reply-To: <7vk3mcnwlj.fsf@alter.siamese.dyndns.org> When a test wants to make sure there is no in an output file, we should just say "! grep string output"; "test_must_fail" is there only to test Git command and catch unusual deaths we know about (e.g. segv) as an error, not as an expected failure. Signed-off-by: Junio C Hamano --- t/README | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/README b/t/README index e669bb3..35b3c5c 100644 --- a/t/README +++ b/t/README @@ -324,6 +324,9 @@ Don't: use 'test_must_fail git cmd'. This will signal a failure if git dies in an unexpected way (e.g. segfault). + On the other hand, don't use test_must_fail for running regular + platform commands; just use '! cmd'. + - use perl without spelling it as "$PERL_PATH". This is to help our friends on Windows where the platform Perl often adds CR before the end of line, and they bundle Git with a version of Perl that