From: Junio C Hamano Date: Thu, 20 Jun 2013 20:10:01 GMT Subject: Re: [PATCH v5 0/5] Reroll patches against v1.8.3.1 Message-ID: <7vppvgsfvq.fsf@alter.siamese.dyndns.org> In-Reply-To: Alexey Shumkin writes: > Alexey Shumkin (5): > t6006 (rev-list-format): don't hardcode SHA-1 in expected outputs > t7102 (reset): don't hardcode SHA-1 in expected outputs > t4205 (log-pretty-formats): don't hardcode SHA-1 in expected outputs > pretty: Add failing tests: user format ignores i18n.logOutputEncoding > setting > pretty: user format ignores i18n.logOutputEncoding setting Next time, please jog readers' memory better by giving a bit more descriptive cover letter. "Reroll" is known by "v5" alrady, and "against v1.8.3.1" certainly helps, but what this series is about is unclear, especially because the end-game patch "user format ignores" is rather badly stated. It is unclear if it is a good thing that user format ignores it and the patch makes sure that is the case, if we currently ignore it in user format and the patch fixes it by making user format pay attention to it, etc. Thanks. > builtin/reset.c | 8 +- > builtin/rev-list.c | 1 + > builtin/shortlog.c | 1 + > log-tree.c | 1 + > submodule.c | 3 + > t/t4041-diff-submodule-option.sh | 25 +++-- > t/t4205-log-pretty-formats.sh | 179 ++++++++++++++++++++------------- > t/t6006-rev-list-format.sh | 209 ++++++++++++++++++++++++--------------- > t/t7102-reset.sh | 37 ++++++- > 9 files changed, 299 insertions(+), 165 deletions(-)