From: Junio C Hamano Date: Tue, 17 Oct 2006 16:12:31 GMT Subject: Re: [PATCH] pack-objects: use of version 3 delta is now optional. Message-ID: <7vodsakjkg.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Nicolas Pitre writes: > On Sun, 15 Oct 2006, Linus Torvalds wrote: > >> Quite frankly, I wonder if the pure "copy size extension" (aka "v3") thing >> is really worth it at all. >> >> I mean, seriously, how much does it buy us? A couple of bytes per every >> 64kB of delta copied? And the downside is that you can't re-use the deltas >> with old clients and/or you have to re-create a "v2" delta at run-time >> from a v3 delta by inflating, fixing and deflating it. > >... > In the mean time, if Junio adds the patch I posted yesterday advertising > the pack version capability over the native protocol then it'll help us > make things forward compatible if ever we decide to go with generating > packs v3 sooner. I've thought about this, but we hopefully would have ofs-delta capability exchanged soon after 1.4.3, and that would be an enough advertisement that the client is recent enough; although it is technically incorrect to tie these two independent features together, the improvement between v2 and v3 is dubious so maybe that is the easiest.