From: Junio C Hamano <junkio@cox.net>
Date: Tue, 20 Feb 2007 18:22:43 GMT
Subject: Re: [PATCH] Teach diff -B about colours
Message-ID: <7vodnovgcs.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0702201506551.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Matthias Lederhofer noticed that `diff -B` did not pick up on diff 
> colournig.

sp.?

> -static void copy_file(int prefix, const char *data, int size)
> +static void copy_file(int prefix, const char *data, int size,
> +		const char *set, const char *reset)
> ...
>  	if (!nl_just_seen)
> -		printf("\n\\ No newline at end of file\n");
> +		printf("%s\n\\ No newline at end of file\n", reset);
>  }

Are you sure about this one?  If preimage lacked terminating LF and
the postimage has it, then don't you want to see "\ No..." as an
addition?